Serve bootstrap and monaco-editor static files locally #27
jriou
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Would be great to not rely on cloudflare CDN to use this app.
I thought about it and I decided to let the browser download those assets in the first release to keep it simple.
I'm okay with your suggestion. But beware of not bloating the server by adding multiple MB to the binary. We should find a way to download a specific version (configurable) of the assets currently hosted on Cloudflare, to include them compressed in the binary (or serve from the filesystem if files exist), then either serve them compressed if possible, or decompress before serving them statically.
@tapiron, I've tried to use npm to download bootstrap and serve those assets locally in #31. Could you tell me if that would work for you please?
I tried to do the same with Monaco but it's slightly more complicated.
Nice, this is more or less what I had in mind when opening this issue!
I'll test this today or tomorrow on my side and let you know if I have some issues.
Could be nice to add a Makefile target for building npm dependencies, but it can be added later.
I have added
make dependenciesin #31.Great, it works well on my side
Thank you. The bootstrap part is now included on the main branch in
ff92e30232.It seems that Ace is easier to integrate. Are you open to replace the Monaco Editor with Ace?
My pull request to replace Monaco by Ace and to serve assets from a local directory is available on #32.
@tapiron, could you check this out please?
Monaco editor replaced by Ace in
b5701b5a4d.