jriou/coller
1
0
Fork 1
Code Issues 9 Pull requests 1 Releases 1 Activity Actions

feat: add possibility to hide upload button #25

Merged
jriou merged 1 commit from tapiron/coller:feat/make_file_upload_button_optional into main 2025-09-15 09:20:51 +02:00
Conversation 5 Commits 1 Files changed 4 +34 -27
tapiron commented 2025-09-12 18:29:03 +02:00
Contributor
Copy link

I was asked to add the possibility to hide the upload button to avoid users confuse this tool for a file sharing app.
This is only on the front.

No breaking changes, by default the button is displayed.

I was asked to add the possibility to hide the upload button to avoid users confuse this tool for a file sharing app. This is only on the front. No breaking changes, by default the button is displayed.
jriou reviewed 2025-09-13 19:06:03 +02:00
src/server/config.go Outdated
@ -25,6 +25,7 @@ type Config struct {
ObservationInterval int `json:"observation_internal"`
Languages []string `json:"languages"`
Language string `json:"language"`
UploadFileButton bool `json:"upload_file_button"`
jriou commented 2025-09-13 19:06:03 +02:00
Owner
Copy link

Could you update the README.md file with this new setting please?

Could you update the [README.md](https://git.riou.xyz/jriou/coller/src/branch/main/src/cmd/collerd/README.md) file with this new setting please?
jriou commented 2025-09-13 19:09:15 +02:00
Owner
Copy link

For booleans, I would like to add an "enable" prefix like enable_upload_file_button.

For booleans, I would like to add an "enable" prefix like `enable_upload_file_button`.
tapiron commented 2025-09-14 19:25:57 +02:00
Author
Contributor
Copy link

Updated variable names, json config key and added doc in README.md.

I also removed useless if statement.

Updated variable names, json config key and added doc in README.md. I also removed useless if statement.
tapiron marked this conversation as resolved
tapiron force-pushed feat/make_file_upload_button_optional from cfdf653c47 to 4944e47e76 2025-09-14 19:24:31 +02:00 Compare
jriou approved these changes 2025-09-15 06:52:22 +02:00
Dismissed
jriou left a comment
Owner
Copy link

LGTM

LGTM
tapiron force-pushed feat/make_file_upload_button_optional from 4944e47e76 to 3f8d42571b 2025-09-15 09:17:54 +02:00 Compare
tapiron commented 2025-09-15 09:19:56 +02:00
Author
Contributor
Copy link

I resolved the conflict, should be good to merge

I resolved the conflict, should be good to merge
jriou approved these changes 2025-09-15 09:20:42 +02:00
jriou merged commit e03aa6b87a into main 2025-09-15 09:20:51 +02:00
jriou commented 2025-09-15 09:21:01 +02:00
Owner
Copy link

Thank you for your contribution!

Thank you for your contribution!
jriou deleted branch feat/make_file_upload_button_optional 2025-09-15 09:21:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
jriou
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jriou/coller#25
No description provided.
Delete branch "tapiron/coller:feat/make_file_upload_button_optional"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?