jriou/coller
1
0
Fork 1
Code Issues 8 Pull requests 2 Releases 1 Activity Actions

feat: set default expiration in select #28

Open
tapiron wants to merge 1 commit from tapiron/coller:feat/display_default_expiration_in_form into main
pull from: tapiron/coller:feat/display_default_expiration_in_form
merge into: jriou:main
Conversation 1 Commits 1 Files changed 2 +3 -1
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/server.go
View file

@ -189,6 +189,7 @@ type PageData struct {
Title string Title string
Version string Version string
Expirations []int Expirations []int
Expiration int
Languages []string Languages []string
Err error Err error
URL string URL string
@ -426,6 +427,7 @@ func (s *Server) Start() error {
p := PageData{ p := PageData{
Title: s.config.Title, Title: s.config.Title,
Expirations: s.config.Expirations, Expirations: s.config.Expirations,
Expiration: s.config.Expiration,
Languages: s.config.Languages, Languages: s.config.Languages,
} }

2
src/server/templates/index.html
View file

@ -36,7 +36,7 @@
</div> </div>
<div class="col"> <div class="col">
<select class="form-select" aria-label="Expiration" id="expiration" name="expiration"> <select class="form-select" aria-label="Expiration" id="expiration" name="expiration">
<option selected="selected" disabled>Expiration</option> <option selected="selected" disabled>{{HumanDuration .Expiration}}</option>
jriou commented 2025-09-13 19:18:08 +02:00
Copy link

Expiration is included in Expirations resulting in a duplicate entry in the list.

Wouldn't it be better to use a selected="selected" attribute when the expiration is the default one instead?

Something like:

<option disabled>Expiration</option>
{{range .Expirations}}
 <option {{if eq . .Expiration}}selected="selected"{{end}} value="{{.}}">{{HumanDuration .}}</option>
{{end}}

I'm not sure about the scope of the variables here but that should be doable. That way, we'll still see it's an expiration thanks to the disabled option but it would automatically select the default value set on the server.

Expiration is included in Expirations resulting in a duplicate entry in the list. Wouldn't it be better to use a `selected="selected"` attribute when the expiration is the default one instead? Something like: ```html <option disabled>Expiration</option> {{range .Expirations}} <option {{if eq . .Expiration}}selected="selected"{{end}} value="{{.}}">{{HumanDuration .}}</option> {{end}} ``` I'm not sure about the scope of the variables here but that should be doable. That way, we'll still see it's an expiration thanks to the disabled option but it would automatically select the default value set on the server.
{{range .Expirations}} {{range .Expirations}}
<option value="{{.}}">{{HumanDuration .}}</option> <option value="{{.}}">{{HumanDuration .}}</option>
{{end}} {{end}}