jriou/coller
1
0
Fork 1
Code Issues Pull requests Releases 5 Activity Actions

feat: set default expiration in select #28

Merged
jriou merged 2 commits from tapiron/coller:feat/display_default_expiration_in_form into main 2025-09-15 06:51:17 +02:00
Conversation 2 Commits 2 Files changed 2 +3 -1
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 16945d488a - Show all commits

feat: set default expiration in select

Prev Next
Thibault Piron 2025-09-12 19:05:41 +02:00
commit 16945d488a
Signed by untrusted user who does not match committer: tapiron
GPG key ID: 37EE240037F90B38

2
src/server/server.go
View file

@ -189,6 +189,7 @@ type PageData struct {
Title string
Version string
Expirations []int
Expiration int
Languages []string
Err error
URL string
@ -426,6 +427,7 @@ func (s *Server) Start() error {
p := PageData{
Title: s.config.Title,
Expirations: s.config.Expirations,
Expiration: s.config.Expiration,
Languages: s.config.Languages,
}

2
src/server/templates/index.html
View file

@ -36,7 +36,7 @@
</div>
<div class="col">
<select class="form-select" aria-label="Expiration" id="expiration" name="expiration">
<option selected="selected" disabled>Expiration</option>
<option selected="selected" disabled>{{HumanDuration .Expiration}}</option>
tapiron marked this conversation as resolved Outdated
jriou commented 2025-09-13 19:18:08 +02:00
Outdated
Copy link

Expiration is included in Expirations resulting in a duplicate entry in the list.

Wouldn't it be better to use a selected="selected" attribute when the expiration is the default one instead?

Something like:

<option disabled>Expiration</option>
{{range .Expirations}}
 <option {{if eq . .Expiration}}selected="selected"{{end}} value="{{.}}">{{HumanDuration .}}</option>
{{end}}

I'm not sure about the scope of the variables here but that should be doable. That way, we'll still see it's an expiration thanks to the disabled option but it would automatically select the default value set on the server.

Expiration is included in Expirations resulting in a duplicate entry in the list. Wouldn't it be better to use a `selected="selected"` attribute when the expiration is the default one instead? Something like: ```html <option disabled>Expiration</option> {{range .Expirations}} <option {{if eq . .Expiration}}selected="selected"{{end}} value="{{.}}">{{HumanDuration .}}</option> {{end}} ``` I'm not sure about the scope of the variables here but that should be doable. That way, we'll still see it's an expiration thanks to the disabled option but it would automatically select the default value set on the server.
tapiron commented 2025-09-14 18:51:20 +02:00
Outdated
Copy link

Yes, it's better like this, done (just used variable instead of implicit "." to be easier to read)

Yes, it's better like this, done (just used variable instead of implicit "." to be easier to read)
{{range .Expirations}}
<option value="{{.}}">{{HumanDuration .}}</option>
{{end}}