feat: set default expiration in select #28

tapiron · 2025-09-12T19:09:35+02:00

tapiron commented

2025-09-12 19:09:35 +02:00

No default value in select could be interpreted as ever lasting note.
Default value in the select makes that clearer.

No default value in select could be interpreted as ever lasting note. Default value in the select makes that clearer.

tapiron added 1 commit

2025-09-12 19:09:36 +02:00

feat: set default expiration in select 16945d488a

jriou requested changes

2025-09-13 19:18:16 +02:00

Dismissed

src/server/templates/index.html Outdated

					
				@ -37,3 +37,3 @@

				                <div class="col">

				                    <select class="form-select" aria-label="Expiration" id="expiration" name="expiration">

				                        <option selected="selected" disabled>Expiration</option>

				                        <option selected="selected" disabled>{{HumanDuration .Expiration}}</option>

jriou commented

2025-09-13 19:18:08 +02:00

Expiration is included in Expirations resulting in a duplicate entry in the list.

Wouldn't it be better to use a selected="selected" attribute when the expiration is the default one instead?

Something like:

<option disabled>Expiration</option>
{{range .Expirations}}
 <option {{if eq . .Expiration}}selected="selected"{{end}} value="{{.}}">{{HumanDuration .}}</option>
{{end}}

I'm not sure about the scope of the variables here but that should be doable. That way, we'll still see it's an expiration thanks to the disabled option but it would automatically select the default value set on the server.

Expiration is included in Expirations resulting in a duplicate entry in the list. Wouldn't it be better to use a `selected="selected"` attribute when the expiration is the default one instead? Something like: ```html <option disabled>Expiration</option> {{range .Expirations}} <option {{if eq . .Expiration}}selected="selected"{{end}} value="{{.}}">{{HumanDuration .}}</option> {{end}} ``` I'm not sure about the scope of the variables here but that should be doable. That way, we'll still see it's an expiration thanks to the disabled option but it would automatically select the default value set on the server.

tapiron commented

2025-09-14 18:51:20 +02:00

Yes, it's better like this, done (just used variable instead of implicit "." to be easier to read)

tapiron marked this conversation as resolved

tapiron added 1 commit

2025-09-14 18:48:51 +02:00

fix: avoid double options ba53cfda22

jriou approved these changes

2025-09-15 06:50:56 +02:00

jriou left a comment

LGTM. Thanks for your contribution!

jriou merged commit 33628331f4 into main