fix: remove double rendering and test error (#26)

Remove double template rendering and test error for non password protected note

Co-authored-by: Thibault Piron <thibault.a.piron@gmail.com>
Reviewed-on: jriou/coller#26
Reviewed-by: Julien Riou <jriou@monitoring@riou.xyz>
Co-authored-by: tapiron <tapiron@monitoring@riou.xyz>
Co-committed-by: tapiron <tapiron@monitoring@riou.xyz>

src/server/server.go

@@ -189,7 +189,6 @@ type PageData struct {
 	Title       string
 	Version     string
 	Expirations []int
-	Expiration  int
 	Languages   []string
 	Err         error
 	URL         string
@@ -346,9 +345,6 @@ func (h *GetWebNoteHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	h.PageData.Err = fmt.Errorf("jriou")
-	h.Templates.ExecuteTemplate(w, templateName, h.PageData)
-
 	h.PageData.Note = note
 
 	h.logger.Debug("rendering note web page")
@@ -427,7 +423,6 @@ func (s *Server) Start() error {
 	p := PageData{
 		Title:       s.config.Title,
 		Expirations: s.config.Expirations,
-		Expiration:  s.config.Expiration,
 		Languages:   s.config.Languages,
 	}
 

src/server/templates/index.html

@@ -36,7 +36,7 @@
                 </div>
                 <div class="col">
                     <select class="form-select" aria-label="Expiration" id="expiration" name="expiration">
-                        <option selected="selected" disabled>{{HumanDuration .Expiration}}</option>
+                        <option selected="selected" disabled>Expiration</option>
                         {{range .Expirations}}
                         <option value="{{.}}">{{HumanDuration .}}</option>
                         {{end}}