jriou/yt-mp3-ui
1
0
Fork 0
Code Activity

[formatsort] Remove misuse of 'preference'

Browse source 
'preference' is to be used only when the format is better that ALL qualities of a lower preference irrespective of ANY sorting order the user requests. See deezer.py for correct use of this

In the older sorting method, `preference`, `quality` and `language_preference` were functionally almost equivalent. So these disparities doesn't really matter there

Also, despite what the documentation says, the default for `preference` was actually 0 and not -1. I have tried to correct this and also account for it when converting `preference` to `quality`
This commit is contained in:
pukkandan 2021-02-19 03:33:16 +05:30
commit f983b87567
61 changed files with 89 additions and 108 deletions
Download patch file Download diff file Expand all files Collapse all files

1
youtube_dlc/extractor/uol.py
View file

@ -110,7 +110,6 @@ class UOLIE(InfoExtractor):
'format_id': format_id,
'url': f_url,
'quality': quality(format_id),
'preference': -1,
})
self._sort_formats(formats)