From 17f0948aebbbbf655ad5077772db02a2aef64298 Mon Sep 17 00:00:00 2001
From: Julien Riou <julien@riou.xyz>
Date: Thu, 26 Nov 2020 14:48:46 +0100
Subject: [PATCH] Add configuration validation with jsonschema

Signed-off-by: Julien Riou <julien@riou.xyz>
---
 .pre-commit-config.yaml                    |  2 ++
 README.md                                  |  4 ++--
 TODO.txt                                   |  1 -
 config.json.example => config.example.json |  0
 config.schema.json                         | 21 +++++++++++++++++++++
 notify-by-telegram.py                      |  9 +++++----
 6 files changed, 30 insertions(+), 7 deletions(-)
 rename config.json.example => config.example.json (100%)
 create mode 100644 config.schema.json

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 503fbbb..a14542e 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -11,6 +11,8 @@ repos:
         args: ['--remove']
       - id: requirements-txt-fixer
       - id: trailing-whitespace
+      - id: check-json
+      - id: check-yaml
   - repo: https://gitlab.com/pycqa/flake8
     rev: master
     hooks:
diff --git a/README.md b/README.md
index 9d6cad2..56220aa 100644
--- a/README.md
+++ b/README.md
@@ -17,14 +17,14 @@ git clone https://github.com/jouir/notify-by-telegram.git /opt/notify-by-telegra
 
 Install dependencies using the package manager:
 ```
-sudo apt install python3-jinja2 python3-requests
+sudo apt install python3-jinja2 python3-requests python3-jsonschema
 ```
 
 ## Configuration
 
 Copy and update the configuration file example:
 ```
-cp -p config.json.example telegram.json
+cp -p config.example.json telegram.json
 vim telegram.json
 sudo mv telegram.json /etc/nagios4/telegram.json
 sudo chown root:nagios /etc/nagios4/telegram.json
diff --git a/TODO.txt b/TODO.txt
index 5d7e48a..da36fd8 100644
--- a/TODO.txt
+++ b/TODO.txt
@@ -1,3 +1,2 @@
-Use JSON schema to validate configuration file
 Add pre-commit Dockerfile and a doc to easily lint the code
 Add requirements.txt file
diff --git a/config.json.example b/config.example.json
similarity index 100%
rename from config.json.example
rename to config.example.json
diff --git a/config.schema.json b/config.schema.json
new file mode 100644
index 0000000..f817acd
--- /dev/null
+++ b/config.schema.json
@@ -0,0 +1,21 @@
+{
+  "type": "object",
+  "properties": {
+    "chat_id": {
+      "type": "number"
+    },
+    "auth_key": {
+      "type": "string"
+    },
+    "host_template": {
+      "type": "string"
+    },
+    "service_template": {
+      "type": "string"
+    }
+  },
+  "required": [
+    "chat_id",
+    "auth_key"
+  ]
+}
diff --git a/notify-by-telegram.py b/notify-by-telegram.py
index 916b4fc..aac48ad 100755
--- a/notify-by-telegram.py
+++ b/notify-by-telegram.py
@@ -6,8 +6,10 @@ import os
 
 import requests
 from jinja2 import Environment, FileSystemLoader
+from jsonschema import validate
 
 logger = logging.getLogger(__name__)
+absolute_path = os.path.split(os.path.abspath(__file__))[0]
 
 
 class InvalidConfigException(Exception):
@@ -60,9 +62,9 @@ def read_config(filename=None):
 def validate_config(config):
     if config is None:
         raise InvalidConfigException('config is not a dict')
-    for key in ['chat_id', 'auth_key']:
-        if key not in config:
-            raise InvalidConfigException(f'missing "{key}" key in config')
+    with open(os.path.join(absolute_path, 'config.schema.json'), 'r') as fd:
+        schema = json.loads(fd.read())
+        validate(instance=config, schema=schema)
 
 
 def setup_logging(args):
@@ -82,7 +84,6 @@ def generate_payload(chat_id, message_type, message_variables, template_file_nam
     # define jinja template name
     if not template_file_name:
         template_name = 'host.md.j2' if message_type == 'host' else 'service.md.j2'
-        absolute_path = os.path.split(os.path.abspath(__file__))[0]
         template_file_name = os.path.join(absolute_path, 'templates', template_name)
     template_path = os.path.dirname(os.path.abspath(template_file_name))
     template_name = os.path.basename(os.path.abspath(template_file_name))